Skip to content

Clean up logging around exceptions #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2017
Merged

Clean up logging around exceptions #3236

merged 3 commits into from
Nov 9, 2017

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 8, 2017 •
edited
Loading

This should reduce some noise, and clean up how we're calling logs.

agjohnson
agjohnson approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericholscher ericholscher merged commit f093076 into master Nov 9, 2017
@stsewd stsewd deleted the fix-more-logging branch August 15, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @agjohnson